Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: try swapping to djlint #329

Open
3 tasks
agjohnson opened this issue Apr 4, 2024 · 0 comments
Open
3 tasks

Lint: try swapping to djlint #329

agjohnson opened this issue Apr 4, 2024 · 0 comments
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

We are currently using djhtml here for html formatting. This package only does part of what djlint does, but was providing nicer html formatting when I first tried both. I did try djlint recently and the formatting was mostly okay. I think we could swap to djlint if we wanted to, as djlint does have some more checks on templates.

Some things to evaluate:

  • Template indentation and formatting looks okay/better with djlint?
  • djlint catches easy to miss things like multiline, single line comments ({# #}), maybe HTML errors?
  • djlint catches/fixes other issues?

This will be a disruptive change, so would hopefully be an obvious choice after playing with djlint a bit more.

@agjohnson agjohnson added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Apr 4, 2024
@agjohnson agjohnson added this to the Deprecation and cleanup milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant