Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: continue altering base message styles #316

Open
agjohnson opened this issue Mar 25, 2024 · 0 comments
Open

Styles: continue altering base message styles #316

agjohnson opened this issue Mar 25, 2024 · 0 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

I have had a number of issues with the default FUI theme styles for .ui.message class elements and would like to unify around two styles: a normal message style for subtle messages to the user and a solid color background for bringing direct attention to errors, warnings, and important information.

Issues

The issues with FUI base styles are:

  • Styles don't match visually with other components like .ui.toast, .ui.segment, etc.
  • They use colors not used anywhere else in the theme. Toast/segment/etc elements use bold, solid color backgrounds where .ui.message uses muted, unsaturated colors.
  • Contrast is too low for accessibility standards on most variations, because of the unsaturated colors.
  • Link colors do not match the message body color

image

Normal

A light version of .ui.message with a colored icon and bold header. Using a light background and color on some of the text allows the message to stand out just enough, without calling for immediate user attention:

A tip notification using the normal styles

For example, a message reworked:

image

An example replacement info message

Inverted

In FUI terms, this is .ui.inverted.message. These blocks are used for more important messages -- errors, warning, and important information -- places we always want the user to notice and read the notification. These don't fit in well in form prose content, but do work really well as alerts:

image

Changes

To look like a purposeful change, the existing examples of .ui.info.message will need to be reworked a little bit:

  • Add header text. This is for faster scanning and matches all the other examples of notificaitons/form errors we're using.
  • Add an icon to help unify the look and feel of all of our notifications/messages.
  • Add a <p> wrapper to make the styles work correctly.

We can do this incrementally by using the .ui.info.notification.message variant for all existing .ui.info.message instances.

@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

1 participant