Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: "Recent searches" does not consider different versions #296

Open
humitos opened this issue Apr 24, 2024 · 1 comment
Open

Search: "Recent searches" does not consider different versions #296

humitos opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Apr 24, 2024

It seems the "Recent searches" shows all the searches performed in the domain. However, in the same domain there could be different versions and even different projects when using subprojects.

We should save the project.slug and version.slug in the recent searches data to know if they match when restoring them from the cache.

How to reproduce:

  1. go to https://test-builds.readthedocs.io/en/latest/
  2. search for "configuration"
  3. click on the result
  4. go to a different version using the flyout
  5. click on the search input from the flyout

At this point, you will see the "Recent search" you perform in a different version. If you click there, you will go to the other version.

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Apr 24, 2024
@zanderle
Copy link
Collaborator

Yeah, I did not consider this at all. On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Status: Planned
Development

No branches or pull requests

2 participants