Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tabbed code blocks allow an unclosed code block? #77

Open
kellyjosephprice opened this issue Nov 18, 2020 · 3 comments
Open

Should tabbed code blocks allow an unclosed code block? #77

kellyjosephprice opened this issue Nov 18, 2020 · 3 comments

Comments

@kellyjosephprice
Copy link
Collaborator

The commonmark spec allows an unclosed code block to extend to the end of the doc. I think we allowed this until #70, but didn't have a test for it?

@kellyjosephprice kellyjosephprice changed the title Should tabbed code blocks allow an unclosed code block Should tabbed code blocks allow an unclosed code block? Nov 18, 2020
@rafegoldberg
Copy link
Contributor

Interesting. So what's the behavior now post-#70? Will it close the code block at the first line break? Or the next block component?

@kellyjosephprice
Copy link
Collaborator Author

It won't match the block at all.

  ` ` `
  "will just be a regular code block"
  ` ` `
  ` ` `
  ` ` `
  tab 1
  ` ` `
  ` ` `
  tab 2
  ` ` `
  ` ` `
  Back to regular formatting

@kellyjosephprice
Copy link
Collaborator Author

Updates, the second trailing-unclosed code block is now parsed as a code block, but not part of the tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants