Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Server Side Rendering, Bump Deps, Now React16 required. #916

Merged

Conversation

virgofx
Copy link
Collaborator

@virgofx virgofx commented Mar 20, 2018

The inclusion of react-portal introduced numerous issues including preventing server side rendering from working correctly. This PR fixes that and also reduces the massive increase in size resulting from that dependency.

Fixes other issues noted in #870 which are currently not fixed in beta.3

Also requires React16 now. This has been talked about for awhile and signed off by @TheSharpieOne and will not pose an issue for most libraries as the transition is seamless.

And lastly, file sizes now back to beta.0 level

169K Mar 20 03:29 reactstrap.cjs.js
265K Mar 20 03:29 reactstrap.cjs.js.map
166K Mar 20 03:29 reactstrap.es.js
264K Mar 20 03:29 reactstrap.es.js.map
284K Mar 20 03:29 reactstrap.full.js
455K Mar 20 03:29 reactstrap.full.js.map
111K Mar 20 03:29 reactstrap.full.min.js
395K Mar 20 03:29 reactstrap.full.min.js.map
168K Mar 20 03:29 reactstrap.js
263K Mar 20 03:29 reactstrap.js.map
 75K Mar 20 03:29 reactstrap.min.js
228K Mar 20 03:29 reactstrap.min.js.map

…x portal references to use ReactDOM directly. Update deps and minimum stability now React16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants