Input elements shouldn't have children

[jhsware]

reactstrap/src/__tests__/Input.spec.js

Line 60 in 0648cc2

it('should render children', () => {

[TheSharpieOne]

They should when the "input" is a <select> or <textarea>, which the Input component can render given type="select" or type="textarea" respectfully.

[jhsware]

The default input type is text so the test should be something like this: <Input type="select">Yo!</Input>

Are you sure type="textarea" is allowed children? The React-clone Inferno.js complains if textarea has children.

[TheSharpieOne]

Sounds like a defect for inferno. <textarea> is not a void element, it allows content within it. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea

Yes, the test itself probably could use type="textarea", but we don't check the type to determine if it can have children (we probably should, it would be simple since we use the type to determine the tag and if the tag is input, we should not allow children).

[jhsware]

React doesn't follow HTML-specs in that regard: https://reactjs.org/docs/forms.html

<textarea value={this.state.value} onChange={this.handleChange} />

Only <select> should have children from what I can tell.

[TheSharpieOne]

Yeah, looks like they are removing the ability for <textarea>s to have children in react 17: facebook/react#11639

[jhsware]

I have made a port of Reactstrap to Inferno.js so I get stuck in the middle at times... :D