Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Custom Form Inputs #534

Closed
bartonwelt opened this issue Aug 10, 2017 · 5 comments
Closed

Support for Custom Form Inputs #534

bartonwelt opened this issue Aug 10, 2017 · 5 comments

Comments

@bartonwelt
Copy link

Is there any plan to support Bootstrap 4 custom form inputs as found here: https://v4-alpha.getbootstrap.com/components/forms/#custom-forms

@carlosmarte
Copy link

carlosmarte commented Sep 17, 2017

@TheSharpieOne I would like to tackle this feature. Currently there are 3 types of custom forms (https://v4-alpha.getbootstrap.com/components/forms/#custom-forms).

  • Checkboxes and radios
  • Select menu
  • File browser

Should i create a file for each one under reactstrap/src/?

  • InputBoxes.js
  • SelectMenu
  • FileBrowser

@TheSharpieOne
Copy link
Member

TheSharpieOne commented Sep 17, 2017

@carlosmarte The docs link is now https://getbootstrap.com/docs/4.0/components/forms/?#custom-forms it is slightly different than the alpha stuff. As far as components and separation, I wouldn't mind if there was a single CustomInput or CustomControl component which had a type prop to control which custom input is rendered.
Besides the inputs here is also a stack class, we could have thst as CustomInputStack or CustomControlStack.

@carlosmarte
Copy link

@TheSharpieOne, just pushed the initial implementation. Would appreciate any feedback before I write the unit test.

Screenshot of custom elements:
image

@Stainzl
Copy link

Stainzl commented Nov 23, 2017

How do I use them when I installed it to via npm install?
My version of reactstrap is 5.0.0-alpha.4

@TheSharpieOne
Copy link
Member

The PR which adds custom inputs has some change requests and hasn't been merged. You'll have to create your own for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants