Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse show deprecated findDomNode in console.log() #1962

Closed
Nawanop opened this issue Sep 7, 2020 · 4 comments
Closed

Collapse show deprecated findDomNode in console.log() #1962

Nawanop opened this issue Sep 7, 2020 · 4 comments
Labels
duplicate

Comments

@Nawanop
Copy link

Nawanop commented Sep 7, 2020 •
edited

  • components: Collapse
  • reactstrap version 8.5.1
  • react version 16.9.48
  • bootstrap version 4.5.2

Console log showing depecated findDomNode in StrictMode

I use Collapse class in Reactstrap and found logging like this
image

react-transition-group 4.4.0 tell that use nodeRef instead of findDomNode to fix this issue
https://github.com/reactjs/react-transition-group/blob/1fd4a65ac45edd2aea3dec18eeb8b9c07c7eb93f/CHANGELOG.md#440-2020-05-05
@mznet
Copy link

mznet commented Sep 14, 2020

@Nawanop This Pull Reuqest already handles this issue. It would be fixed if this PR is merged.

@Nawanop
Copy link
Author

Nawanop commented Sep 15, 2020

@mznet thank you so much

@irfancnk
Copy link

irfancnk commented Oct 2, 2020

Getting the same error, waiting for the solution

@kyletsang kyletsang mentioned this issue Oct 8, 2020
Closed
@kyletsang
Copy link
Member

Consolidating in #1833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kyletsang @mznet @irfancnk @Nawanop