Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Progress bar /> does not add attributes #1847

Closed
DaddyWarbucks opened this issue Jun 13, 2020 · 0 comments · Fixed by #1919 or #1967
Closed

<Progress bar /> does not add attributes #1847

DaddyWarbucks opened this issue Jun 13, 2020 · 0 comments · Fixed by #1919 or #1967

Comments

@DaddyWarbucks
Copy link

  • components: Progress
  • reactstrap version #8.4.1
  • import method es
  • react version #16.6.1
  • bootstrap version #4.3.1

What is happening?

The id prop is not being passed to nested <Progress bar /> (note the bar prop). This line

if (bar) {
returns ProgressBar without applying the {...attributes}

What should be happening?

The <Progress bar/> with bar prop should behave like <Progress /> where the id (and other props) are passed to the underlying <Tag>

Code

https://stackblitz.com/edit/reactstrap-drizhz?file=Example.js

watinha added a commit to watinha/reactstrap that referenced this issue Jul 5, 2020
watinha added a commit to watinha/reactstrap that referenced this issue Jul 5, 2020
iamandrewluca pushed a commit that referenced this issue Jul 6, 2020
* Passing attributes to nested Progress bar component (FIX ##1847)

* FIX #1847: passes attributes to nested Progress bar component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants