Ignore empty writes to Buffer

[clue]

Empty writes should not wait for writable event from the event loop and then literally try to do nothing.

Without this change, it would otherwise wait for the Buffer to return from a superfluous fwrite($resource, '') call.

[cboden]

LGTM

On Aug 19, 2016, 9:54 AM -0400, Christian Lück notifications@github.com, wrote:

Empty writes should not wait for writable event from the event loop and then literally try to do nothing.

Without this change, it would otherwise wait for the Buffer to return from a superfluous fwrite($resource, '') call.

You can view, comment on, or merge this pull request online at:

#51

Commit Summary
Ignore empty writes to Buffer

File Changes
M src/Buffer.php (https://github.com/reactphp/stream/pull/51/files#diff-0) (2)
M tests/BufferTest.php (https://github.com/reactphp/stream/pull/51/files#diff-1) (30)

Patch Links:
https://github.com/reactphp/stream/pull/51.patch
https://github.com/reactphp/stream/pull/51.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#51), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAls3i_WYzt_FSqZ4Wf6hABsgUwutGnKks5qhbV3gaJpZM4JofsK).

[WyriHaximus]

LGTM