Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support STARTTLS #89

Open
clue opened this issue Apr 10, 2017 · 3 comments
Open

Support STARTTLS #89

clue opened this issue Apr 10, 2017 · 3 comments

Comments

@clue
Copy link
Member

clue commented Apr 10, 2017

Originally reported 2016-10-04 by @arnaud-lb: reactphp-legacy/socket-client#69

clue pushed a commit to clue-labs/socket that referenced this issue Apr 22, 2017
Forward compatibility with Stream v0.5 and upcoming v0.6
@ghost ghost mentioned this issue Apr 10, 2019
@clue clue added this to the v1.5.0 milestone Dec 31, 2019
@clue clue modified the milestones: v1.5.0, v1.6.0 May 17, 2020
@clue clue modified the milestones: v1.6.0, v1.7.0 Aug 4, 2020
@clue clue modified the milestones: v1.7.0, v1.8.0 Jun 24, 2021
@clue clue removed this from the v1.8.0 milestone Jul 11, 2021
@ellisonpatterson
Copy link

Any possibility this will ever be supported?

@clue
Copy link
Member Author

clue commented May 3, 2022

@ellisonpatterson Definitely on the roadmap and would love to see this feature! 👍

That said, there are currently no immediate plans to build this from my end (no demand at the moment and more important outstanding issues currently), but we always welcome PRs! If you need this for a commercial project and you want to help sponsor this feature, feel free to reach out and I'm happy to take a look.

@WyriHaximus
Copy link
Member

@clue @ellisonpatterson Spent the better part of this today looking into voryx/PgAsync#38 and it looks like STARTTLS, or put better, the ability to enable TLS encryption on a connection at some point after the connection has been opened and used is required there as well. Had a look at #199 and it looks overly complex for what we need.

In short, we need the tls connection context and the ability to enable the TLS when both sides negotiate to be ready for it. Most of what is required for this is already in this package. I'll look into how this can be achieved without breaking out current API, if a break is required this could land in v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants