Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on PHP 8.2 #466

Merged
merged 1 commit into from Aug 23, 2022
Merged

Test on PHP 8.2 #466

merged 1 commit into from Aug 23, 2022

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Aug 13, 2022

With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.

Refs: reactphp/event-loop#258
Builds on top of #459

@WyriHaximus WyriHaximus added this to the v1.7.0 milestone Aug 13, 2022
@WyriHaximus WyriHaximus marked this pull request as ready for review August 23, 2022 05:38
@WyriHaximus WyriHaximus requested a review from clue August 23, 2022 05:38
@WyriHaximus
Copy link
Member Author

@clue With a fix from PHPUnit's side yesterday, all checks are now green 🎉

With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.

Refs: reactphp/event-loop#258
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for the update, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants