Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with upcoming Promise v3 #460

Merged
merged 2 commits into from Sep 3, 2022

Conversation

clue
Copy link
Member

@clue clue commented Jun 22, 2022

@clue
Copy link
Member Author

clue commented Aug 24, 2022

Rebased to fix merge conflict now that #464 has been merged. There are still a couple of failing tests that look like some unexpected behavior changes in Promise v3 as also noticed by @WyriHaximus in reactphp/socket#214 (comment). Considering the HTTP component depends on the Socket component, let's continue this discussion in the upstream PR. I'll make sure to update this PR once we make progress.

@clue
Copy link
Member Author

clue commented Aug 26, 2022

Updated to use Socket v1.12.0 and apply the same changes to fix a race in the tests as discussed in reactphp/socket#214 (comment), so the build should now be green. This is still WIP as this currently still depends on updated dev dependencies that I'll try to get shipped no later than next week.

@clue clue force-pushed the promise-v3 branch 2 times, most recently from a0399bd to 78cfb44 Compare September 2, 2022 14:39
@clue clue changed the title [WIP] Forward compatibility with upcoming Promise v3 Forward compatibility with upcoming Promise v3 Sep 2, 2022
@clue
Copy link
Member Author

clue commented Sep 2, 2022

Updated to stable releases now that all dependencies have been released:

Also worked around another nasty HHVM build error because legacy HHVM does not support the iterable type in Promise v3 (reactphp/promise#225).

This is now ready for review :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants