Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite to skip memory tests when lowering memory limit does not work #440

Merged
merged 1 commit into from Feb 5, 2022

Conversation

clue
Copy link
Member

@clue clue commented Feb 4, 2022

This simple changeset updates the test suite to skip memory tests when lowering memory limit does not work. This only affects the test suite and is a bit harder to reproduce in this repository itself, but I've stumbled over this while updating ReactPHP's combined test suite that runs all tests of all components and happens to use a few bytes more than the current limit.

I'll link the downstream PR against this one, a failed test run can be seen here: https://github.com/clue-labs/reactphp/runs/5063358894?check_suite_focus=true#step:5:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants