Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ini settings for file uploads #250

Closed
clue opened this issue Nov 17, 2017 · 1 comment
Closed

Respect ini settings for file uploads #250

clue opened this issue Nov 17, 2017 · 1 comment

Comments

@clue
Copy link
Member

clue commented Nov 17, 2017

Now that we've started offering a way to buffer incoming request bodies (#216 and #235) and parse incoming request bodies (#220 and #226), we may want to look into supporting PHP's default ini settings to control this behavior.

For example, these are the relevant default settings on my Ubuntu box:

file_uploads		On
max_file_uploads	20
max_input_nesting_level	64
max_input_vars		1000
upload_max_filesize	2M

post_max_size		128M
max_input_time 		-1 # hardcoded for CLI
memory_limit	 	256M # parallel requests?

See also http://php.net/manual/en/info.configuration.php and http://php.net/manual/en/ini.core.php.

@clue
Copy link
Member Author

clue commented Nov 21, 2017

I'd like to make this actionable, so see #255 and #257 instead 👍

@clue clue closed this as completed Nov 21, 2017
@clue clue removed this from the v0.8.0 milestone Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant