Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #820 When invoking SendManyInner#unvoid, propagate the success/failure from the new promise to SendManyInner #824

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added this to the 0.8.11.RELEASE milestone Aug 28, 2019
@violetagg violetagg requested a review from smaldini August 28, 2019 13:42
…ilure from the new promise to SendManyInner
@codecov-io
Copy link

Codecov Report

Merging #824 into 0.8.x will increase coverage by 0.06%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.8.x     #824      +/-   ##
============================================
+ Coverage     66.21%   66.27%   +0.06%     
+ Complexity     1381     1379       -2     
============================================
  Files           132      132              
  Lines          6440     6446       +6     
  Branches        846      848       +2     
============================================
+ Hits           4264     4272       +8     
+ Misses         1726     1716      -10     
- Partials        450      458       +8
Impacted Files Coverage Δ Complexity Δ
.../main/java/reactor/netty/channel/MonoSendMany.java 67.21% <50%> (+0.41%) 4 <0> (ø) ⬇️
...c/main/java/reactor/netty/channel/FluxReceive.java 77% <0%> (-0.5%) 61% <0%> (-1%)
src/main/java/reactor/netty/ReactorNetty.java 70% <0%> (-0.41%) 38% <0%> (-1%)
...ctor/netty/resources/PooledConnectionProvider.java 78.79% <0%> (ø) 21% <0%> (-1%) ⬇️
.../java/reactor/netty/channel/ChannelOperations.java 92.3% <0%> (ø) 61% <0%> (ø) ⬇️
...eactor/netty/http/server/HttpServerOperations.java 72.53% <0%> (+0.42%) 63% <0%> (ø) ⬇️
...eactor/netty/http/client/HttpClientOperations.java 64.7% <0%> (+0.58%) 71% <0%> (ø) ⬇️
...r/netty/http/server/WebsocketServerOperations.java 64.19% <0%> (+1.23%) 19% <0%> (ø) ⬇️
...eactor/netty/channel/ChannelOperationsHandler.java 75% <0%> (+1.92%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495fa36...67de9c0. Read the comment docs.

@violetagg violetagg changed the title fix #820 Do not cleanup the queue if there is no termination signal. fix #820 When invoking SendManyInner#unvoid, propagate the success/failure from the new promise to SendManyInner Aug 28, 2019
@violetagg violetagg merged commit 67de9c0 into 0.8.x Aug 28, 2019
@violetagg violetagg deleted the issue-820 branch August 28, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants