Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of "X-Forwarded-Host" to support "host:port" #2711

Closed
rstoyanchev opened this issue Mar 1, 2023 · 0 comments · Fixed by #2712
Closed

Handling of "X-Forwarded-Host" to support "host:port" #2711

rstoyanchev opened this issue Mar 1, 2023 · 0 comments · Fixed by #2712
Assignees
@violetagg
Labels
type/enhancement A general enhancement
Milestone
1.0.29

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 1, 2023 •
edited

After Spring Framework switched to using HttpServerRequest#hostAddress first instead of parsing the "Host" header in spring-projects/spring-framework#28601 in order to ensure forwarded headers take effect.

However, as reported in spring-projects/spring-boot#34395 and discussed under spring-projects/spring-framework#30033, if "X-Forwarded-Host" has host and port, e.g. "localhost:3000" then HttpServerRequest#hostAddress returns a hostString with the port in it. It would be useful to parse that since it can happen.
@rstoyanchev rstoyanchev added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Mar 1, 2023
@violetagg violetagg self-assigned this Mar 1, 2023
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Mar 1, 2023
@violetagg violetagg added this to the 1.0.29 milestone Mar 1, 2023
violetagg added a commit that referenced this issue Mar 1, 2023
@violetagg
Handling X-Forwarded-Host with value host:port
5c8832d 
Fixes #2711
@violetagg violetagg mentioned this issue Mar 1, 2023
Merged
@rstoyanchev rstoyanchev mentioned this issue Mar 1, 2023
Closed
@violetagg violetagg linked a pull request Mar 1, 2023 that will close this issue
Handling X-Forwarded-Host with value host:port #2712
Merged
@rstoyanchev rstoyanchev mentioned this issue Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.29
Development

Successfully merging a pull request may close this issue.

Handling X-Forwarded-Host with value host:port reactor/reactor-netty
2 participants
@rstoyanchev @violetagg