Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ConnectionProvider.Builder#disposeInactivePoolsInBackground #2607

Merged
merged 3 commits into from Dec 9, 2022

Conversation

violetagg
Copy link
Member

Test HTTP/1.1 and HTTP/2 with/without enabled eviction in background.

…Background

Test HTTP/1.1 and HTTP/2 with/without enabled eviction in background.
@violetagg violetagg added the for/reactor-core This belongs to the Reactor Core project label Dec 8, 2022
@violetagg violetagg added this to the 1.0.26 milestone Dec 8, 2022
@violetagg violetagg requested a review from a team December 8, 2022 14:24
@violetagg violetagg changed the title Add test for ConnectionProvider.Builder#disposeInactivePoolsInBackground Add test for ConnectionProvider.Builder#disposeInactivePoolsInBackground Dec 8, 2022
@violetagg
Copy link
Member Author

@pderop I added additional commit to ensure the test is passing on all OSes

Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg added type/chore A task not related to code (build, formatting, process, ...) and removed for/reactor-core This belongs to the Reactor Core project labels Dec 9, 2022
@violetagg violetagg merged commit d124dcf into 1.0.x Dec 9, 2022
@violetagg violetagg deleted the connection-pool-test-dispose-inactive-pools branch December 9, 2022 09:37
violetagg added a commit that referenced this pull request Dec 9, 2022
@violetagg violetagg added type/test A general test and removed type/chore A task not related to code (build, formatting, process, ...) labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test A general test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants