New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With Java toolchain in place AllowRedefinitionToAddDeleteMethods is not needed #2352
Conversation
…ot needed The exception below is thrown when Java version specified in the PATH is > 8 Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods' Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods' Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. Process 'Gradle Test Executor 159' finished with non-zero exit value 1 org.gradle.process.internal.ExecException: Process 'Gradle Test Executor 159' finished with non-zero exit value 1 at org.gradle.process.internal.DefaultExecHandle$ExecResultImpl.assertNormalExitValue(DefaultExecHandle.java:414) at org.gradle.process.internal.worker.DefaultWorkerProcess.onProcessStop(DefaultWorkerProcess.java:141) at org.gradle.process.internal.worker.DefaultWorkerProcess.access$000(DefaultWorkerProcess.java:42) at org.gradle.process.internal.worker.DefaultWorkerProcess$1.executionFinished(DefaultWorkerProcess.java:94)
/cc @berngp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, I have missed the problem because I have used java11 when testing previous PR.
LGTM
Java version is now 8 for compiling, tests and javadoc
@reactor/netty-team PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pderop @simonbasle Thanks |
The exception below is thrown when Java version specified in the
PATH
is> 8