Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Java toolchain in place AllowRedefinitionToAddDeleteMethods is not needed #2352

Merged
merged 4 commits into from Jul 4, 2022

Conversation

violetagg
Copy link
Member

The exception below is thrown when Java version specified in the PATH is > 8

Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Process 'Gradle Test Executor 159' finished with non-zero exit value 1
org.gradle.process.internal.ExecException: Process 'Gradle Test Executor 159' finished with non-zero exit value 1
        at org.gradle.process.internal.DefaultExecHandle$ExecResultImpl.assertNormalExitValue(DefaultExecHandle.java:414)
        at org.gradle.process.internal.worker.DefaultWorkerProcess.onProcessStop(DefaultWorkerProcess.java:141)
        at org.gradle.process.internal.worker.DefaultWorkerProcess.access$000(DefaultWorkerProcess.java:42)
        at org.gradle.process.internal.worker.DefaultWorkerProcess$1.executionFinished(DefaultWorkerProcess.java:94)

…ot needed

The exception below is thrown when Java version specified in the PATH is > 8

Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Unrecognized VM option 'AllowRedefinitionToAddDeleteMethods'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Process 'Gradle Test Executor 159' finished with non-zero exit value 1
org.gradle.process.internal.ExecException: Process 'Gradle Test Executor 159' finished with non-zero exit value 1
        at org.gradle.process.internal.DefaultExecHandle$ExecResultImpl.assertNormalExitValue(DefaultExecHandle.java:414)
        at org.gradle.process.internal.worker.DefaultWorkerProcess.onProcessStop(DefaultWorkerProcess.java:141)
        at org.gradle.process.internal.worker.DefaultWorkerProcess.access$000(DefaultWorkerProcess.java:42)
        at org.gradle.process.internal.worker.DefaultWorkerProcess$1.executionFinished(DefaultWorkerProcess.java:94)
@violetagg violetagg added the type/enhancement A general enhancement label Jul 4, 2022
@violetagg violetagg added this to the 1.0.21 milestone Jul 4, 2022
@violetagg violetagg requested a review from a team July 4, 2022 09:33
@violetagg
Copy link
Member Author

/cc @berngp

Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I have missed the problem because I have used java11 when testing previous PR.

LGTM

@violetagg
Copy link
Member Author

@reactor/netty-team PTAL

Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop @simonbasle Thanks

@violetagg violetagg merged commit 185e58b into 1.0.x Jul 4, 2022
@violetagg violetagg deleted the java-toolchain branch July 4, 2022 15:48
violetagg added a commit that referenced this pull request Jul 4, 2022
violetagg added a commit that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants