Adopt Gradle Toolchain for the JDK #2343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopting the Gradle Toolchain for the JDK will make the build _safer_ in machines that have multiple JDKs installed and that by mistake can build the project using a JDK higher than the intended. As defined in [Gradle's docs](https://docs.gradle.org/current/userguide/toolchains.html), the toolchains will give us... > Executing the build (e.g. using gradle check) will now handle several things for you and others running your build > Setup all compile, test and javadoc tasks to use the defined toolchain which may be different than the one Gradle itself uses > Gradle detects locally installed JVMs > Gradle chooses a JRE/JDK matching the requirements of the build (in this case a JVM supporting Java 8) > If no matching JVM is found, it will automatically download a matching JDK from AdoptOpenJDK
|
@reactor/netty-team PTAL |
violetagg
approved these changes
Jul 4, 2022
pderop
approved these changes
Jul 4, 2022
|
The failed test on Windows OS is not relevant |
violetagg
pushed a commit
that referenced
this pull request
Jul 4, 2022
Adopting the Gradle Toolchain for the JDK will make the build _safer_ in machines that have multiple JDKs installed and that by mistake can build the project using a JDK higher than the intended. As defined in [Gradle's docs](https://docs.gradle.org/current/userguide/toolchains.html), the toolchains will give us... > Executing the build (e.g. using gradle check) will now handle several things for you and others running your build > Setup all compile, test and javadoc tasks to use the defined toolchain which may be different than the one Gradle itself uses > Gradle detects locally installed JVMs > Gradle chooses a JRE/JDK matching the requirements of the build (in this case a JVM supporting Java 8) > If no matching JVM is found, it will automatically download a matching JDK from AdoptOpenJDK
violetagg
added a commit
that referenced
this pull request
Jul 4, 2022
violetagg
added a commit
that referenced
this pull request
Jul 4, 2022
|
Thank you @violetagg for all your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting the Gradle Toolchain for the JDK will make the build safer in machines that have multiple JDKs
installed and that by mistake can build the project using a JDK higher than the intended.
As defined in Gradle's docs, the toolchains will give us...