Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create method with metrics parameter in ConnectionProvider (#2313) #2314

Merged
merged 3 commits into from Jun 23, 2022
Merged

Add create method with metrics parameter in ConnectionProvider (#2313) #2314

merged 3 commits into from Jun 23, 2022

Conversation

tuguri8
Copy link
Contributor

@tuguri8 tuguri8 commented Jun 21, 2022

Add create method with name, maxConnections, metricsEnabled parameters.

Related to #2313

@violetagg violetagg added the type/enhancement A general enhancement label Jun 22, 2022
@violetagg violetagg added this to the 1.0.21 milestone Jun 22, 2022
violetagg
violetagg requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuguri8 Thanks for the PR. Only one small addition that provides information in which version this method was added.

reactor-netty-core/src/main/java/reactor/netty/resources/ConnectionProvider.java Show resolved Hide resolved
@violetagg
Copy link
Member

@tuguri8 We need to exclude this new static method from the compatibility check. Please add to build.gradle

diff --git a/reactor-netty-core/build.gradle b/reactor-netty-core/build.gradle
index 951caf774..67913b06e 100644
--- a/reactor-netty-core/build.gradle
+++ b/reactor-netty-core/build.gradle
@@ -194,6 +194,9 @@ task japicmp(type: JapicmpTask) {
 	ignoreMissingClasses = true
 	includeSynthetic = true
 	onlyIf { "$compatibleVersion" != "SKIP" }
+	methodExcludes = [
+			"reactor.netty.resources.ConnectionProvider#create(java.lang.String, int, boolean)"
+	]
 }
 
 tasks.japicmp.dependsOn(downloadBaseline)

@violetagg violetagg linked an issue Jun 22, 2022 that may be closed by this pull request
Provide a static method to enable metrics with custom name, maxConnections in ConnectionProvider #2313
Closed
@tuguri8 tuguri8 force-pushed the 2313-createWithMetricsInConnectionProvider branch from 231f0c7 to 05ad456 Compare June 22, 2022 15:47
@tuguri8 tuguri8 requested a review from violetagg June 22, 2022 15:50
violetagg
violetagg approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reactor/netty-team PTAL

@violetagg violetagg requested a review from a team June 22, 2022 16:25
pderop
pderop approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@violetagg
Copy link
Member

@pderop Thanks for the review

@violetagg violetagg merged commit 3a9fcc0 into reactor:1.0.x Jun 23, 2022
violetagg added a commit that referenced this pull request Jun 23, 2022
@violetagg
Merge #2314 into 1.1.0-M4
c348d70
violetagg added a commit that referenced this pull request Jun 23, 2022
@violetagg
Merge #2314 into netty5
337d864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

@violetagg violetagg violetagg approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.21
Development

Successfully merging this pull request may close these issues.

Provide a static method to enable metrics with custom name, maxConnections in ConnectionProvider
3 participants
@tuguri8 @violetagg @pderop