Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/3 support #1531

Open
violetagg opened this issue Mar 5, 2021 · 5 comments
Open

HTTP/3 support #1531

violetagg opened this issue Mar 5, 2021 · 5 comments
Assignees
Labels
type/enhancement A general enhancement
Milestone

Comments

@violetagg
Copy link
Member

https://netty.io/news/2021/03/04/http3-0-0-1-Final.html
https://github.com/netty/netty-incubator-codec-http3

@violetagg violetagg added the type/enhancement A general enhancement label Mar 5, 2021
@violetagg violetagg added this to the 1.1.x Backlog milestone Mar 5, 2021
@violetagg violetagg modified the milestones: 2.0.x Backlog, 1.1.x Backlog Jan 28, 2022
@violetagg violetagg modified the milestones: 1.1.x Backlog, 2.0.x Backlog May 16, 2022
@fokion
Copy link

fokion commented Oct 31, 2023

Can I have a look ?

@violetagg
Copy link
Member Author

@fokion Yes sure. Thanks!
May be start experimenting with main branch (1.1.x version) as a base, because it will be hard with netty5 branch (2.0.x)

@fokion
Copy link

fokion commented Nov 9, 2023

Noticed that we are compiling with jdk 8 but in mac os with apple silicon I got the following error

> Failed to calculate the value of task ':reactor-netty-core:compileJava' property 'javaCompiler'.
   > Unable to download toolchain matching the requirements ({languageVersion=8, vendor=any, implementation=vendor-specific}) from 'https://api.adoptium.net/v3/binary/latest/8/ga/mac/aarch64/jdk/hotspot/normal/eclipse'.
      > Could not read 'https://api.adoptium.net/v3/binary/latest/8/ga/mac/aarch64/jdk/hotspot/normal/eclipse' as it does not exist.


So I tried migrating to JDK 17 which had its own challenges
fokion@bba09f5

@violetagg
Copy link
Member Author

Noticed that we are compiling with jdk 8 but in mac os with apple silicon I got the following error

> Failed to calculate the value of task ':reactor-netty-core:compileJava' property 'javaCompiler'.
   > Unable to download toolchain matching the requirements ({languageVersion=8, vendor=any, implementation=vendor-specific}) from 'https://api.adoptium.net/v3/binary/latest/8/ga/mac/aarch64/jdk/hotspot/normal/eclipse'.
      > Could not read 'https://api.adoptium.net/v3/binary/latest/8/ga/mac/aarch64/jdk/hotspot/normal/eclipse' as it does not exist.

So I tried migrating to JDK 17 which had its own challenges fokion@bba09f5

Reactor Netty 2.0.x (which is still on milestone phases) is based on Java 17 and Netty 5, unfortunately we still don't have Netty HTTP3 ported for Netty 5

Reactor Netty 1.1.x is base on Java 8 and Netty 4 and there we have Netty HTTP3. There are no plans to move 1.1.x on Java 17.

So may be try to install Java 8 manually (for example via sdkman etc) and try again the build, it should be ok.

@fokion
Copy link

fokion commented Nov 10, 2023

Ok good to know , will point my jdk back to 8 and work on this assumption. Thanks for the assistance.

violetagg added a commit that referenced this issue Apr 11, 2024
- QuicSslContextBuilder does not extend SslContextBuilder.
- Add Http3SslContextSpec, similar to Http2SslContextSpec and Http11SslContextSpec.

Related to #1531
violetagg added a commit that referenced this issue Apr 12, 2024
violetagg added a commit that referenced this issue Apr 16, 2024
- QuicSslContextBuilder does not extend SslContextBuilder.
- Add Http3SslContextSpec, similar to Http2SslContextSpec and Http11SslContextSpec.

Related to #1531
violetagg added a commit that referenced this issue Apr 16, 2024
@violetagg violetagg self-assigned this Apr 17, 2024
violetagg added a commit that referenced this issue Apr 23, 2024
violetagg added a commit that referenced this issue Apr 23, 2024
violetagg added a commit that referenced this issue Apr 23, 2024
violetagg added a commit that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants