Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures context restored in RetrySpec #3316

Merged
merged 2 commits into from Dec 12, 2022
Merged

ensures context restored in RetrySpec #3316

merged 2 commits into from Dec 12, 2022

Conversation

OlegDokuka
Copy link
Contributor

@OlegDokuka OlegDokuka commented Dec 9, 2022

closes #3314

This PR restores context for inner Flux inside concatMap, while the concatMap leaves remain without context. It allows Retry methods to have context

Signed-off-by: Oleh Dokuka odokuka@vmware.com

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@OlegDokuka OlegDokuka added type/bug A general bug warn/regression A regression from a previous release area/context This issue is related to the Context labels Dec 9, 2022
@OlegDokuka OlegDokuka requested a review from a team as a code owner December 9, 2022 11:54
@OlegDokuka OlegDokuka changed the base branch from main to 3.4.x December 9, 2022 11:54
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@OlegDokuka OlegDokuka merged commit cfe1979 into 3.4.x Dec 12, 2022
@OlegDokuka OlegDokuka deleted the bugfix/3.4.x-#3314 branch December 12, 2022 09:48
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka OlegDokuka added this to the 3.5.1 milestone Dec 12, 2022
chemicL pushed a commit that referenced this pull request Mar 7, 2023
closes #3314

This commit restores context for inner Flux inside concatMap, while the concatMap remains without context. It allows Retry methods to have context while onErrorContinue to be disabled for retry concatMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/context This issue is related to the Context type/bug A general bug warn/regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context is empty if retrieved in RetrySpec since version 3.4.25
3 participants