Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: Sinks.one()#tryEmitValue(null) #3287

Merged
merged 1 commit into from Nov 23, 2022
Merged

Fix regression: Sinks.one()#tryEmitValue(null) #3287

merged 1 commit into from Nov 23, 2022

Conversation

simonbasle
Copy link
Member

@simonbasle simonbasle commented Nov 17, 2022 •
edited

This commit fixes a regression where passing a null value to the
Sinks.one() tryEmitValue method was no longer interpreted as
tryEmitEmpty().

Fixes #3284.

@simonbasle simonbasle requested a review from a team as a code owner November 17, 2022 17:29
@simonbasle simonbasle added this to the 3.5.1 milestone Nov 17, 2022
@simonbasle simonbasle added type/bug A general bug warn/regression A regression from a previous release labels Nov 17, 2022
@simonbasle simonbasle self-assigned this Nov 17, 2022
@simonbasle
Copy link
Member Author

marked this as 3.5.1 but the issue as 3.4.26 on purpose to indicate that it should land in both versions

@OlegDokuka OlegDokuka merged commit 8573237 into 3.4.x Nov 23, 2022
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka OlegDokuka deleted the 3284-sinksOneTryEmitValueEmptyRegression branch November 23, 2022 08:33
OlegDokuka added a commit that referenced this pull request Nov 23, 2022
@OlegDokuka
Merge #3287 into 3.5.1
2148ac3 
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
chemicL pushed a commit that referenced this pull request Mar 7, 2023
@simonbasle @chemicL
Fix regression: Sinks.one()#tryEmitValue(null) (#3287)
ba9957e 
Fixes #3284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees

@simonbasle simonbasle

Labels
type/bug A general bug warn/regression A regression from a previous release
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonbasle @reactorbot @OlegDokuka