Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf baseline 3.5.0, adapt Shakespeare bench to 2022.0.0 release #3278

Merged
merged 1 commit into from Nov 14, 2022
Merged

Perf baseline 3.5.0, adapt Shakespeare bench to 2022.0.0 release #3278

merged 1 commit into from Nov 14, 2022

Conversation

simonbasle
Copy link
Member

The benchmarks project is ready to move to the 3.5.x baseline, now
that all 2022.0.0 artifacts are released. That said, the Shakespear
benchmark still uses deprecated ElasticScheduler, which is removed in
3.5.0.

This commit switches the benchmark to use BoundedElasticScheduler in
addition to upgrading the perf dependencies to 3.5.0.

Fixes #3277.

@simonbasle
Adapt Shakespear perf benchmark to 2022.0.0 release
c97f14f 
The `benchmarks` project is ready to move to the 3.5.x baseline, now
that all 2022.0.0 artifacts are released. That said, the Shakespear
benchmark still uses deprecated ElasticScheduler, which is removed in
3.5.0.

This commit switches the benchmark to use BoundedElasticScheduler in
addition to upgrading the perf dependencies to 3.5.0.

Fixes #3277.
@simonbasle simonbasle requested a review from a team as a code owner November 8, 2022 10:53
@simonbasle simonbasle added type/chores A task not related to code (build, formatting, process, ...) type/dependency-upgrade A dependency upgrade (possibly via bot) labels Nov 8, 2022
@simonbasle simonbasle self-assigned this Nov 8, 2022
@simonbasle simonbasle requested a review from a team November 8, 2022 10:53
@simonbasle simonbasle added this to the 3.5.1 milestone Nov 8, 2022
@simonbasle simonbasle changed the title Adapt Shakespear perf benchmark to 2022.0.0 release Perf baseline 3.5.0, adapt Shakespeare bench to 2022.0.0 release Nov 14, 2022
@simonbasle simonbasle merged commit bd49521 into main Nov 14, 2022
@simonbasle simonbasle deleted the updateBenchmarkPerfbaseline branch November 14, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetagg violetagg violetagg approved these changes

Assignees

@simonbasle simonbasle

Labels
type/chores A task not related to code (build, formatting, process, ...) type/dependency-upgrade A dependency upgrade (possibly via bot)
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Adapt shakespear perf benchmark to 3.5.0
2 participants
@simonbasle @violetagg