Add logging in Exceptions.throwIf[Jvm]Fatal, add isFatal methods #3122
+229
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @elefeint |
chemicL
reviewed
Jul 22, 2022
chemicL
approved these changes
Jul 22, 2022
OlegDokuka
approved these changes
Jul 22, 2022
|
note: the tests that assert logs could benefit from test features added in #3123 |
This commit improves the discoverability of exceptions that are "fatal" to Reactor by: - adding `Exceptions.isFatal` and `Exceptions.isJvmFatal` methods - adding logging to `Exceptions.throwIfFatal` and `Exceptions.throwIfJvmFatal` just before a fatal exception is thrown This should at least help pinpointing such occurrences from the logs, in cases where the thrown exception bubble all the way up the stack of a thread with no uncaughtExceptionHandler for example. Fixes #3111.
simonbasle
force-pushed
the
3111-logInThrowIfFatal
branch
from
f8f2f34 to
7c93a85
Compare
|
rebased on top of 3.4.x since #3123 has now been merged. will also adapt the throwIfFatal test to make use of new JUnit5 extension |
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the discoverability of exceptions that are "fatal"
to Reactor by:
Exceptions.isFatalandExceptions.isJvmFatalmethodsExceptions.throwIfFatalandExceptions.throwIfJvmFataljust before a fatal exception is thrownThis should at least help pinpointing such occurrences from the logs,
in cases where the thrown exception bubble all the way up the stack of
a thread with no uncaughtExceptionHandler for example.
Fixes #3111.