Implement variant of windowTimeout with fairBackpressure #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
This reverts commit 9a76d65.
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
simonbasle
requested changes
Jun 10, 2022
| @@ -177,7 +179,12 @@ public static void race(int timeoutSeconds, Scheduler s, final Runnable... rs) { | |||
|
|
|||
| try { | |||
| if (!cdl.await(timeoutSeconds, TimeUnit.SECONDS)) { | |||
| throw new AssertionError("RaceTestUtils.race wait timed out after " + timeoutSeconds + "s"); | |||
| throw new AssertionError("RaceTestUtils.race wait timed out after " + timeoutSeconds + "s" + Thread.getAllStackTraces() | |||
There was a problem hiding this comment.
this looks potentially very verbose for the general case? maybe add an overload that does the allStackTraces appending?
There was a problem hiding this comment.
I'd suggest adding an overload with a boolean collectAllStackTraces parameter
| import reactor.util.context.Context; | ||
|
|
||
| /** | ||
| * @author David Karnok |
There was a problem hiding this comment.
I think you can add yourself here too @OlegDokuka 😆
reactor-core/src/main/java/reactor/core/publisher/FluxWindowTimeout.java
Outdated
Show resolved
Hide resolved
| int received = this.received + 1 ; | ||
| this.received = received; | ||
|
|
||
| this.queue.offer(t); |
There was a problem hiding this comment.
should we guard against an already cancelled window here and directly discard each element before they get a chance to be added to the queue?
reactor-core/src/main/java/reactor/core/publisher/FluxWindowTimeout.java
Outdated
Show resolved
Hide resolved
reactor-core/src/main/java/reactor/core/publisher/FluxWindowTimeout.java
Outdated
Show resolved
Hide resolved
reactor-core/src/main/java/reactor/core/publisher/FluxWindowTimeout.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
simonbasle
approved these changes
Jun 10, 2022
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Jun 10, 2022
simonbasle
pushed a commit
that referenced
this pull request
Jun 15, 2022
This commit improves the InnerWindow.sendNext method to guard against attempts at sending more than the window's maxSize elements, earlier in the codepath. It also removes an unused method that was left-in during iterations on the backpressure-aware new implementation from #3054.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.