-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async fusion bug: extra fixes and changes #3046
Conversation
simonbasle
commented
May 19, 2022
- WIP try to fix other fusion issues, doFinally and doAfterTerminate not fuseable
- fix hanging: StepVerifierBuilder cancels upstream AFTER propagating onError in ASYNC mode
- remove doFinally fuseable-related unreachable code
- fix tests: no fusion in doFinally, NONE negotiation in MonoPeekTerminal
the rationale for these changes: I started implementing an ArchUnit rule to surface other cases where a Subscriber is a QueueSubscription but doesn't implement I tried to fix it and noticed that in the .doFinally(sig -> signals.add("finally"))
.doOnError(e -> signals.add("onError")) then the On the other hand, this exploration also surfaced the fact that fused Lastly, in |
…nError in ASYNC mode
d7cb912
to
65d3d2f
Compare
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |