Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitchOnFirst better tracks in/out premature close #2794

Merged
merged 4 commits into from Sep 28, 2021

Conversation

OlegDokuka
Copy link
Contributor

This PR adds an extra state to indicate the scenario when the downstream cancels / receives an error before the inner upstream was terminated. In that case, we generate inbound prematurely close to propagate extra cancellation exception
Signed-off-by: Oleh Dokuka odokuka@vmware.com

@OlegDokuka OlegDokuka requested a review from a team as a code owner September 28, 2021 08:50
@OlegDokuka OlegDokuka changed the title fixes improperly dropped error adds extra state to SwitchOnFirst state machine Sep 28, 2021
@OlegDokuka OlegDokuka force-pushed the bugfix/sof-premature-close-fix branch 3 times, most recently from 14c5f49 to 091c52c Compare September 28, 2021 09:31
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
@simonbasle simonbasle linked an issue Sep 28, 2021 that may be closed by this pull request
@simonbasle simonbasle changed the title adds extra state to SwitchOnFirst state machine SwitchOnFirst better tracks in/out premature close Sep 28, 2021
@simonbasle simonbasle merged commit af0b3e8 into main Sep 28, 2021
@simonbasle simonbasle deleted the bugfix/sof-premature-close-fix branch September 28, 2021 12:51
@simonbasle simonbasle added this to the 3.4.11 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwitchOnFirst stress test: investigate flaky test
2 participants