Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document possible alternative to replay ManySink limit(0) #2787

Merged
merged 1 commit into from Sep 24, 2021
Merged

Document possible alternative to replay ManySink limit(0) #2787

merged 1 commit into from Sep 24, 2021

Conversation

simonbasle
Copy link
Member

This commit documents limit(Duration.ZERO) as a possible alternative
to Sinks.many().replay().limit(0), which is forbidden.

Fixes #2772.

@simonbasle
Document possible alternative to replay ManySink limit(0)
7b2267e 
This commit documents `limit(Duration.ZERO)` as a possible alternative
to `Sinks.many().replay().limit(0)`, which is forbidden.

Fixes #2772.
@simonbasle simonbasle requested a review from a team as a code owner September 24, 2021 08:22
@simonbasle simonbasle added this to the 3.4.11 milestone Sep 24, 2021
@simonbasle simonbasle added the type/documentation A documentation update label Sep 24, 2021
@simonbasle simonbasle self-assigned this Sep 24, 2021
@simonbasle simonbasle requested a review from a team September 24, 2021 08:22
OlegDokuka
OlegDokuka approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbasle simonbasle merged commit a024120 into main Sep 24, 2021
@simonbasle simonbasle deleted the 2772-documentSinkReplayZero branch September 24, 2021 09:34
@hevara247 hevara247 mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees

@simonbasle simonbasle

Labels
type/documentation A documentation update
Projects
None yet
Milestone
3.4.11
Development

Successfully merging this pull request may close these issues.

Cannot create a replay sink with zero size
2 participants
@simonbasle @OlegDokuka