Align Mono#share() behavior with Flux#share, split sink impl out #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO copy tests and amend NextProcessorTest
simonbasle
force-pushed
the
2680-monoShareCacheInconsistencies
branch
from
84814b7
to
1fc32c6
Compare
simonbasle
changed the title
chemicL
added a commit
that referenced
this pull request
Mar 6, 2024
Similarly to Flux#share, Mono#share also cancels the source when all Subscribers have cancelled. This change improves the documentation. Following #2680 and #2756 there exists a misalignment in the javadoc for Mono#share method. Since cancelling the source is a fact, the javadoc is now improved instead of changing the behaviour. Resolves #3740
chemicL
added a commit
that referenced
this pull request
Mar 6, 2024
Similarly to Flux#share, Mono#share also cancels the source when all Subscribers have cancelled. This change improves the documentation. Following #2680 and #2756 there exists a misalignment in the javadoc for Mono#share method. Since cancelling the source is a fact, the javadoc is now improved instead of changing the behaviour. Resolves #3740
chemicL
added a commit
that referenced
this pull request
Mar 7, 2024
Similarly to `Flux#share`, `Mono#share` also cancels the source when all `Subscriber`s have cancelled. This change improves the documentation. Following #2680 and #2756 there exists a misalignment in the javadoc for `Mono#share` method. Since cancelling the source is a fact, the javadoc is now improved instead of changing the behaviour. Resolves #3740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mono.share().subscribe()returns a dedicatedDisposableNextProcessor(which can then beterminated) is still reachable through
mono.toProcessor()(deprecated)mono.share()subscribers behaves like a reference countedmulticast, ie the same as
Flux#share: upstream is cancelled and next incomingsubscriber will trigger an upstream re-subscription
Sinks.one()by splitting out the implementationinto
SinkOneMulticastNextProcessorTestforSinkOneMulticastTestFixes #2680.