Fix missed SwitchOnFirst drain and inner stream cancel #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
bugfix/sof-3
branch
from
8370a4e
to
7ec4671
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
bugfix/sof-3
branch
from
7ec4671
to
69bda60
Compare
simonbasle
approved these changes
Mar 18, 2020
simonbasle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the hanging test (https://github.com/reactor/reactor-core/compare/master...OlegDokuka:bugfix/sof-3?expand=1#diff-c590f0f2fbe1d419bdccc521a1894278L215)
For some reasons, I was thinking that if first is null then we should drain, but in fact, we have to always do that;
Since the drain is delivering value and onComplete may be called before downstream has appeared or requested at least once I added 2 extra checks for those purposes
Added Inner stream erroring if it appeared after the parent cancellation happened (to make sure disconnected inner stream will not be hanged for forever)
Refactoring to make sure code is not duplicating that much
Signed-off-by: Oleh Dokuka shadowgun@i.ua