fix #1251 Make defer opt-in in VirtualTimeScheduler.create
#2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te()` method
This was referenced Jan 19, 2020
simonbasle
approved these changes
Jan 22, 2020
simonbasle
added
the
warn/behavior-change
simonbasle
changed the title
defer parameter to VirtualTimeScheduler.create() methoddefer opt-in in VirtualTimeScheduler.create
|
Thanks for the PR 🎁 @yarosla 🙇 |
|
Thanks for great project! |
simonbasle
added a commit
that referenced
this pull request
Mar 9, 2020
A change in #2017 introduced a regression that prevented externally initialized VirtualTimeSchedulers to be used in StepVerifier. This commit allows the StepVerifier to once again discover an already set VTS instance and use it, taking the `defer` parameter into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1251
See also conversation in #2012