Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it fully buildable on JDK 8 (including the StackWalker usage) #1483

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

bsideup
Copy link
Contributor

@bsideup bsideup commented Jan 8, 2019

No description provided.

@bsideup bsideup added type/chores A task not related to code (build, formatting, process, ...) area/java9 This belongs to the java9 compatibility theme labels Jan 8, 2019
@simonbasle simonbasle added this to the 3.2.5.RELEASE milestone Jan 8, 2019
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #1483 into master will increase coverage by 0.03%.
The diff coverage is 80.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1483      +/-   ##
============================================
+ Coverage     84.11%   84.14%   +0.03%     
- Complexity     3897     3898       +1     
============================================
  Files           359      359              
  Lines         29790    29831      +41     
  Branches       5522     5531       +9     
============================================
+ Hits          25057    25101      +44     
+ Misses         3101     3095       -6     
- Partials       1632     1635       +3
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/reactor/core/publisher/Traces.java 70.62% <80.95%> (+3.96%) 25 <0> (ø) ⬇️
...va/reactor/core/publisher/ParallelMergeReduce.java 68.59% <0%> (-1.66%) 3% <0%> (ø)
...ava/reactor/core/publisher/WorkQueueProcessor.java 69.42% <0%> (-0.42%) 19% <0%> (ø)
...java/reactor/core/publisher/FluxSwitchOnFirst.java 73.98% <0%> (-0.34%) 3% <0%> (ø)
...c/main/java/reactor/core/publisher/FluxReplay.java 84.16% <0%> (-0.32%) 25% <0%> (ø)
...eactor/core/publisher/ParallelMergeSequential.java 80.31% <0%> (+0.51%) 7% <0%> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxConcatMap.java 90.42% <0%> (+0.56%) 7% <0%> (ø) ⬇️
...java/reactor/core/scheduler/ExecutorScheduler.java 79.86% <0%> (+0.69%) 12% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxCreate.java 86.63% <0%> (+0.99%) 8% <0%> (ø) ⬇️
.../java/reactor/core/publisher/BlockingIterable.java 78.12% <0%> (+1.04%) 7% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9dcdb...25f29f4. Read the comment docs.

@simonbasle simonbasle merged commit 41b50e4 into master Jan 8, 2019
@simonbasle simonbasle deleted the jdk8_build branch January 8, 2019 09:00
bsideup added a commit that referenced this pull request Jan 28, 2019
(including the StackWalker usage, as a stub)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/java9 This belongs to the java9 compatibility theme type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants