-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Asciidoctor's JRuby #1479
Conversation
# Conflicts: # gradle/doc.gradle
I guess that's something to squash 💃 |
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
============================================
+ Coverage 84.19% 84.25% +0.06%
Complexity 3911 3911
============================================
Files 359 359
Lines 29760 29760
Branches 5527 5527
============================================
+ Hits 25056 25074 +18
+ Misses 3078 3070 -8
+ Partials 1626 1616 -10
Continue to review full report at Codecov.
|
@bsideup for future reference AsciidoctorJ 1.6.0 (newly released) pulls in JRuby 9.2.5.0. When the gradle plugin pulls 1.6.0 we can remove this explicit dependency if needed. |
To build on JDK 9+, we need to update JRuby to 9.2.1.0 or higher.
This branch builds fine on Bamboo:
https://build.spring.io/browse/REACTOR-RNEXT288-3