Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asciidoctor #1477

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Update asciidoctor #1477

merged 2 commits into from
Jan 2, 2019

Conversation

bsideup
Copy link
Contributor

@bsideup bsideup commented Jan 2, 2019

This PR cleanups Asciidoctor dependencies and moves pdf backend off the build classpath to the asciidoctor task's runtime instead.

Also see:
https://asciidoctor.org/docs/asciidoctor-gradle-plugin/#adding-custom-extensions

@bsideup bsideup added the type/chores A task not related to code (build, formatting, process, ...) label Jan 2, 2019
@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #1477 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1477      +/-   ##
============================================
+ Coverage     84.16%   84.51%   +0.34%     
- Complexity     3907     4228     +321     
============================================
  Files           359      359              
  Lines         29760    30488     +728     
  Branches       5527     5674     +147     
============================================
+ Hits          25048    25766     +718     
- Misses         3083     3092       +9     
- Partials       1629     1630       +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/reactor/core/publisher/RingBuffer.java 70.56% <0%> (-0.95%) 24% <0%> (ø)
...re/src/main/java/reactor/util/context/Context.java 83.87% <0%> (-0.75%) 22% <0%> (+3%)
...main/java/reactor/core/publisher/FluxGenerate.java 69.32% <0%> (-0.62%) 7% <0%> (ø)
...ava/reactor/core/publisher/WorkQueueProcessor.java 69.42% <0%> (-0.42%) 19% <0%> (ø)
...e/src/main/java/reactor/util/context/Context5.java 100% <0%> (ø) 29% <0%> (+1%) ⬆️
...e/src/main/java/reactor/util/context/Context3.java 100% <0%> (ø) 21% <0%> (+1%) ⬆️
...rc/main/java/reactor/core/publisher/FluxIndex.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...e/src/main/java/reactor/util/context/Context4.java 100% <0%> (ø) 25% <0%> (+1%) ⬆️
...e/src/main/java/reactor/util/context/Context2.java 100% <0%> (ø) 24% <0%> (+8%) ⬆️
...c/main/java/reactor/core/publisher/FluxReplay.java 84.31% <0%> (+0.15%) 25% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510a0fa...8c98e88. Read the comment docs.

@simonbasle
Copy link
Member

dependency insights on the asciidoctor sourceSet:

asciidoctor
+--- org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16
|    +--- org.asciidoctor:asciidoctorj:1.5.5 -> 1.5.8.1
|    |    +--- org.jruby:jruby-complete:9.1.17.0
|    |    \--- com.beust:jcommander:1.35
|    \--- org.jruby:jruby-complete:9.1.12.0 -> 9.1.17.0
+--- org.asciidoctor:asciidoctorj:1.5.8.1 (*)
\--- org.asciidoctor:asciidoctorj-groovy-dsl:1.0.0.Alpha3
     +--- org.codehaus.groovy:groovy:2.4.15
     \--- org.asciidoctor:asciidoctorj:1.5.5 -> 1.5.8.1 (*)

@simonbasle simonbasle merged commit 518b121 into master Jan 2, 2019
@simonbasle simonbasle added this to the 3.2.4.RELEASE milestone Jan 2, 2019
@simonbasle simonbasle deleted the update_asciidoctor branch January 2, 2019 16:00
simonbasle added a commit that referenced this pull request Jan 7, 2019
This is a hand-made partial cherry pick of the following commits:
 - 21243b3 - Update Asciidoctor's JRuby (#1479)
 - 518b121 - Bump and rework asciidoctor integration (#1477)
 - 74177c5 - Bump tools for Java 11 and Gradle 4.10.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants