Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix indentation in code example. #1471

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

pavelhoral
Copy link
Contributor

@pavelhoral pavelhoral commented Dec 20, 2018

There are a lot of inconsistencies in code examples within the documentation. Some examples are using tab indentation, some 2 spaces, some 4 spaces. However this one was messy to a point that it wasn't readable in the generated document.

Obvious Fix

@pivotal-issuemaster
Copy link

@pavelhoral Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@pavelhoral This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@simonbasle
Copy link
Member

Thanks @pavelhoral, don't hesitate to submit a PR covering more of these indentation inconsistencies if you feel they're also a problem 👍

@simonbasle simonbasle merged commit 408b9bf into reactor:master Dec 20, 2018
@simonbasle simonbasle added this to the 3.2.4.RELEASE milestone Dec 20, 2018
@simonbasle simonbasle added type/documentation A documentation update type/chores A task not related to code (build, formatting, process, ...) labels Dec 20, 2018
@pavelhoral
Copy link
Contributor Author

The question is what is the preferred method of indentation... it is a bit messy right now.

I am not sure if you are following Spring's Code Style guidelines and if those guidelines are relevant for code examples in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...) type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants