fix #1408 Add ability to multi-decorate backing ExecutorServices #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
============================================
+ Coverage 84.2% 84.34% +0.13%
- Complexity 3869 3896 +27
============================================
Files 357 357
Lines 29349 29509 +160
Branches 5452 5495 +43
============================================
+ Hits 24712 24888 +176
+ Misses 3035 3027 -8
+ Partials 1602 1594 -8
Continue to review full report at Codecov.
|
madgnome
reviewed
Oct 25, 2018
| static ScheduledExecutorService decorateExecutorService(String schedulerType, | ||
| String description, Supplier<? extends ScheduledExecutorService> supplier) { | ||
| final Tuple2<String, String> metadata = Tuples.of(schedulerType, description); | ||
| ScheduledExecutorService result = factory.decorateExecutorService(schedulerType, supplier); |
There was a problem hiding this comment.
Before this PR, the provided wrapper executor service would have been the outer most one (since there could be only one) but here it will be the inner most one. I'm wondering if we should keep this behaviour and call factory.decorateExecutorService at the end.
There was a problem hiding this comment.
that makes sense, and easy enough to do 👍
simonbasle
force-pushed
the
1408-schedulersServiceDecorator
branch
from
d219e29
to
c0c3aae
Compare
reactorbot
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smaldini I wonder if the
decorateExecutorServicemethod at theSchedulerslevel should be made accessible to outside implementors ofScheduler(since outside implementations would need to call it in order for the decorators to be applied to internals)