Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava 3.1.x support #283

Closed
linux-china opened this issue Mar 31, 2022 · 8 comments · Fixed by #287
Closed

RxJava 3.1.x support #283

linux-china opened this issue Mar 31, 2022 · 8 comments · Fixed by #287
Labels
for/user-attention This issue needs user attention (feedback, rework, etc...) good first issue Ideal for a new contributor, we'll help help wanted We need contributions on this type/enhancement A general enhancement
Milestone

Comments

@linux-china
Copy link

From RxJava 3.1.1 https://github.com/ReactiveX/RxJava/releases/tag/v3.1.1

The operator fusion-related interfaces and two atomic queue implementations have been promoted to standard, thus officially supported in the io.reactivex.rxjava3.operators package. ReactiveX/RxJava#7320

The package for following classes changed:

  • QueueFuseable
  • QueueDisposable
  • QueueSubscription
  • ScalarSupplier
  • SimpleQueue
  • SimplePlainQueue
  • SpscArrayQueue
  • SpscLinkedArrayQueue

And RxJava3Adapter can not work with RxJava 3.1.x version.

@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Mar 31, 2022
@simonbasle simonbasle added type/enhancement A general enhancement help wanted We need contributions on this status/need-decision This needs a decision from the team for/user-attention This issue needs user attention (feedback, rework, etc...) and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Apr 12, 2022
@simonbasle
Copy link
Member

Can you pinpoint what is breaking exactly? IIRC the RxJava3 adapater doesn't use any of these classes explicitly. I'm also wondering about the need to support RxJava 3.0.x?

@linux-china
Copy link
Author

linux-china commented Apr 12, 2022

From https://github.com/reactor/reactor-addons/blob/main/reactor-adapter/src/main/java/reactor/adapter/rxjava/RxJava3Adapter.java

The following classes are not available from RxJava 3.1.1

import io.reactivex.rxjava3.internal.operators.completable.CompletableFromPublisher;
import io.reactivex.rxjava3.internal.operators.single.SingleFromPublisher;
import io.reactivex.rxjava3.internal.subscriptions.SubscriptionHelper;

@simonbasle
Copy link
Member

indeed, got it. so what's the play here? we have to break support for RxJava 3.0.x and 3.1.0 in a patch release :/
any idea how the user base sizes compare between RxJava 3.0 and 3.1.1 ?

@linux-china
Copy link
Author

I have no idea about this :) Now in my project, and I just inlined 4 interfaces in my jar:

image

I think it's ok to upgrade RxJava 3.1.x and document this change.

@semistone
Copy link

semistone commented Sep 6, 2022

latest micronaut uses 3.1.5, I think it's better to upgrade.
RxJava3.0 user could still use the old version

@guillaumelamirand
Copy link
Contributor

Do you have any update on supporting rxjava 3.1+?

@marcambier
Copy link

Hello !
This problem is critical for us, and avoids the use of rxJava 3.1.
In RxJava 3.1 release note , it's specified that the 3.0.x patch line won't be developed further.
Any progression of having a reactor-addons compatible with rxJava 3.1 ?

marcambier pushed a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 19, 2022
This temporary downgrades rxJava from 3.1 to 3.0, due to reactor-addons incompatibility
see reactor/reactor-addons#283
marcambier pushed a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 19, 2022
This temporary downgrades rxJava from 3.1 to 3.0, due to reactor-addons incompatibility
see reactor/reactor-addons#283
@OlegDokuka
Copy link
Contributor

@linux-china @marcambier and others, would you like to make a contribution?

@OlegDokuka OlegDokuka added good first issue Ideal for a new contributor, we'll help and removed status/need-decision This needs a decision from the team labels Oct 20, 2022
@simonbasle simonbasle added this to the 3.4.9 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/user-attention This issue needs user attention (feedback, rework, etc...) good first issue Ideal for a new contributor, we'll help help wanted We need contributions on this type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants