Throw specific BlockingOperationError instead of Error #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhchandra Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bhchandra Thank you for signing the Contributor License Agreement! |
bsideup
suggested changes
Oct 28, 2019
agent/src/main/java/reactor/blockhound/BlockingOperationError.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Oct 28, 2019
bsideup
reviewed
Oct 28, 2019
agent/src/main/java/reactor/blockhound/BlockingOperationError.java
Outdated
Show resolved
Hide resolved
…o demonstrate that there is no magic in BlockingOperationError and any error can be used (reactor#64)
|
@bsideup thank you for reviewing. Just want to point out that the Readme should also need to be changed.
Shall I convert |
bhchandra
commented
Oct 29, 2019
agent/src/main/java/reactor/blockhound/BlockingOperationError.java
Outdated
Show resolved
Hide resolved
|
@bhchandra good catch! Yes, please change the class in README too 👍 |
bsideup
reviewed
Oct 29, 2019
agent/src/main/java/reactor/blockhound/BlockingOperationError.java
Outdated
Show resolved
Hide resolved
|
@bhchandra merged 🎉 thank you! 👍 |
bsideup
added a commit
that referenced
this pull request
Oct 30, 2019
To make it easier to maintain the tests and not rely on any string assertions, we should use the `BlockingOperationError` type that was introduced in #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64.