Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported libraries section added to readme to resolve issue #44 #60

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Supported libraries section added to readme to resolve issue #44 #60

merged 3 commits into from
Oct 21, 2019

Conversation

tarungulati1988
Copy link
Contributor

Fixes 44

  • Added supported libraries section to readme

@pivotal-issuemaster
Copy link

@tarungulati1988 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@tarungulati1988 Thank you for signing the Contributor License Agreement!

bsideup
bsideup reviewed Oct 10, 2019
View reviewed changes
README.md Outdated
@@ -59,6 +59,10 @@ Where:
|`$LATEST_MILESTONE`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=blue&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fmilestone%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/milestone/io/projectreactor/tools/blockhound/)|
|`$LATEST_SNAPSHOT`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=orange&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fsnapshot%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/snapshot/io/projectreactor/tools/blockhound/)|

## Supported Libraries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this section to "Built-in Integrations" and link to https://github.com/reactor/BlockHound/blob/master/docs/custom_integrations.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure

bsideup
bsideup reviewed Oct 10, 2019
View reviewed changes
README.md Outdated
@@ -59,6 +59,10 @@ Where:
|`$LATEST_MILESTONE`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=blue&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fmilestone%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/milestone/io/projectreactor/tools/blockhound/)|
|`$LATEST_SNAPSHOT`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=orange&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fsnapshot%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/snapshot/io/projectreactor/tools/blockhound/)|

## Supported Libraries
1. [Project Reactor](https://projectreactor.io)
2. [RxJava](https://github.com/ReactiveX/RxJava)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use "RxJava 2" here, to not confuse RxJava 1 users?

bsideup
bsideup reviewed Oct 10, 2019
View reviewed changes
README.md Outdated
@@ -59,6 +59,10 @@ Where:
|`$LATEST_MILESTONE`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=blue&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fmilestone%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/milestone/io/projectreactor/tools/blockhound/)|
|`$LATEST_SNAPSHOT`|[![](https://img.shields.io/badge/dynamic/xml.svg?label=&color=orange&query=%2F%2Fmetadata%2Fversioning%2Flatest&url=https%3A%2F%2Frepo.spring.io%2Fsnapshot%2Fio%2Fprojectreactor%2Ftools%2Fblockhound%2Fmaven-metadata.xml)](https://repo.spring.io/snapshot/io/projectreactor/tools/blockhound/)|

## Supported Libraries
1. [Project Reactor](https://projectreactor.io)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we rename to "built-in integrations", we should say "Project Reactor 3.2.x", and mention that starting with Reactor 3.3.0, it comes with built-in support that uses the SPI

@bsideup bsideup added the type/documentation A documentation update label Oct 10, 2019
@bsideup bsideup added this to the next milestone Oct 10, 2019
@tarungulati1988
Copy link
Contributor Author

@bsideup Are any more changes needed for this PR?

@bsideup
Copy link
Contributor

bsideup commented Oct 21, 2019

@tarungulati1988

Thanks a lot for your contribution! I adjusted the wording a bit, I hope you don't mind :)

P.S. sorry it took so long, was having a short post-S1P vacation :)

@tarungulati1988
Copy link
Contributor Author

@bsideup thats perfectly fine, thank you :)

@bsideup bsideup merged commit f0064db into reactor:master Oct 21, 2019
@tarungulati1988 tarungulati1988 deleted the ISSUE_44 branch October 21, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup left review comments

Assignees
No one assigned
Labels
type/documentation A documentation update
Projects
None yet
Milestone
1.0.1.RELEASE
Development

Successfully merging this pull request may close these issues.

Make it clear that it supports RxJava and other technologies too
3 participants
@tarungulati1988 @pivotal-issuemaster @bsideup