Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that it supports RxJava and other technologies too #44

Closed
bsideup opened this issue Aug 25, 2019 · 1 comment · Fixed by #60
Closed

Make it clear that it supports RxJava and other technologies too #44

bsideup opened this issue Aug 25, 2019 · 1 comment · Fixed by #60
Labels
good first issue Ideal for a new contributor, we'll help type/documentation A documentation update

Comments

@bsideup
Copy link
Contributor

bsideup commented Aug 25, 2019

As was reported by @breun, we should mention that BlockHound is not only for Project Reactor and that it does support other technologies (e.g. it comes with RxJava integration already)
@bsideup bsideup added good first issue Ideal for a new contributor, we'll help type/documentation A documentation update labels Aug 25, 2019
@bsideup bsideup pinned this issue Aug 25, 2019
@tarungulati1988
Copy link
Contributor

Please can I take this up?

@tarungulati1988 tarungulati1988 mentioned this issue Oct 10, 2019
Merged
tarungulati1988 added a commit to tarungulati1988/BlockHound that referenced this issue Oct 10, 2019
@tarungulati1988
Supported libraries added to README, resolves Issue reactor#44
f89e06a 
Code review comments incorporated - 1
bsideup pushed a commit that referenced this issue Oct 21, 2019
@tarungulati1988 @bsideup
Fix #44 by stating which libraries are supported OOTB in README (#60)
f0064db 
- add Reactor's built-in integration mention to README
- add RxJava's built-in integration mention to README
@bsideup bsideup unpinned this issue Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for a new contributor, we'll help type/documentation A documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supported libraries section added to readme to resolve issue #44 tarungulati1988/BlockHound
2 participants
@bsideup @tarungulati1988