Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): add guidance on TypeScript in README #525

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

setsun
Copy link
Contributor

@setsun setsun commented Jul 23, 2019

Description

Adds a short section about TypeScript to the README.md, to provide guidance to users who may be using TypeScript in their projects.

To-do

There could be a section added about flow-typed, though I am unfamiliar with that particular workflow.

@ar5had
Copy link

ar5had commented Sep 5, 2019

It would be better to add what version of @types/react-transition-group, one should install. When install react-transition-group@1.x then even by installing types by npm install @types/react-transition-group, TS will complain about declaration file.

I got past around this issue by installing npm install @types/react-transition-group@1.x. Not sure that's the right way but it solves the problem on my side.

@jquense jquense merged commit f4e6428 into reactjs:master Sep 5, 2019
@jquense
Copy link
Collaborator

jquense commented Sep 5, 2019

thanks!

@jquense
Copy link
Collaborator

jquense commented Sep 5, 2019

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setsun setsun deleted the patch-1 branch September 5, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants