Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more strict about detecting react class components #397

Merged
merged 1 commit into from Oct 25, 2019
Merged

Be more strict about detecting react class components #397

merged 1 commit into from Oct 25, 2019

Conversation

danez
Copy link
Collaborator

@danez danez commented Oct 25, 2019

Previously a class just needed to have a render method.
Now it in addition requires to have a superclass as well.

Also adds support for React.PureComponent in isReactComponentClass.js

Subset of #354

@danez
fix: be more strict about detecting react class components
6ef9ffa 
Previously a class just needed to have a `render` method.
Now it in addition requires to have a superclass as well.
@danez danez added the bug label Oct 25, 2019
@danez danez merged commit b3601b6 into master Oct 25, 2019
@danez danez added the breaking label Oct 25, 2019
@danez danez deleted the strict-class-detection branch October 25, 2019 20:16
@vladar vladar mentioned this pull request Jun 3, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danez