Added handleTSIndexedAccessType. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Jun 17, 2019
| typeParams, | ||
| ); | ||
|
|
||
| // We only get the signature if the objectType is a type (vs interface) |
There was a problem hiding this comment.
Why not for interfaces?
There was a problem hiding this comment.
@devongovett actually I'm not 100% sure why, but I believe in my trial and error when defining the objectType as an interface, there is no signature property on it. I'm not sure if it is related to the discussion here?
Edit:
// getTSType.js Line 185
function handleTSInterfaceDeclaration(path: NodePath): FlowSimpleType {
// Interfaces are handled like references which would be documented separately,
// rather than inlined like type aliases.
return {
name: path.node.id.name,
};
}
|
@thchia, thanks a lot for working on this. Whats the process on this PR? |
|
@sylvesteraswin at this stage I’m still waiting on any additional comments from @devongovett :) |
|
I think we need to look at interfaces in a separate change. I think the change (for object types) makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
I'm new to working with ASTs, and welcome any feedback. I also had some issues with type narrowing in Flow, resulting in the use of
$Shape<>.