Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TSMappedType #362

Merged
merged 1 commit into from Jul 14, 2019
Merged

Add support for TSMappedType #362

merged 1 commit into from Jul 14, 2019

Conversation

ahutchings
Copy link
Contributor

Refs #361

@ahutchings
Copy link
Contributor Author

ahutchings commented May 20, 2019 •
edited

Not sure if we should merge this - the name of the type parameter ("key" in the test case) is currently lost in the translation to the object signature.

@danez
Copy link
Collaborator

danez commented May 25, 2019

@devongovett Can you please have a look at this?

@danez
Copy link
Collaborator

danez commented Jul 14, 2019

We can add the name of the key later if there is demand, but we also do not add it for flow atm.

@danez danez merged commit e59360e into reactjs:master Jul 14, 2019
@ahutchings ahutchings deleted the feature/typescript-mapped-type branch August 14, 2019 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
improvement typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahutchings @danez @devongovett