docs(shareReplay): remove marble diagram #7051
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,9 +143,10 @@ export function shareReplay<T>(bufferSize?: number, windowTime?: number, schedul | |||
| * @see {@link share} | |||
| * @see {@link publishReplay} | |||
| * | |||
| * @param {Number} [bufferSize=Infinity] Maximum element count of the replay buffer. | |||
There was a problem hiding this comment.
Docs builder is smart enough to understand the default value and the type, so declaring them is not necessary:
They only have to match by name.
benlesh
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since we never had marble diagram image for
shareReplay, it can be removed from the docs.Related issue (if exists):
Closes #6989