Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RxJS now supports tslib 2.x, rather than just 2.1.x #6692

Merged
merged 1 commit into from Nov 29, 2021
Merged

fix: RxJS now supports tslib 2.x, rather than just 2.1.x #6692

merged 1 commit into from Nov 29, 2021

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Nov 29, 2021

resolves #6689

@benlesh benlesh requested a review from cartant November 29, 2021 21:13
kwonoj
kwonoj approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine, tslib is stable in general.

One thing to note is we were moving to direction to remove tslib itself with adjusting compilation target (as it reduces boilerplate code)

#6295

@benlesh benlesh merged commit 0b2495f into ReactiveX:master Nov 29, 2021
@benlesh benlesh deleted the fix-issue-6689-tslib-restrictions branch November 29, 2021 22:46
benlesh added a commit that referenced this pull request Nov 29, 2021
@benlesh
fix: RxJS now supports tslib 2.x, rather than just 2.1.x (#6692)
d5d98bc 
resolves #6689
@benlesh benlesh added 7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@cartant cartant Awaiting requested review from cartant

Assignees
No one assigned
Labels
7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support tslib 2.3.0+
2 participants
@benlesh @kwonoj