fix: takeWhile Boolean constructor types

[josepot]

I think that the typings for the Boolean constructor of takeWhile are off... For instance, I think that the following dtslint test:

const c = of(
  false as const,
  0 as const,
  "hi" as const,
  -0 as const,
  0n as const,
  "" as const,
  null,
  undefined
).pipe(takeWhile(Boolean)); // $ExpectType Observable<false | "" | 0 | 0n | "hi" | null | undefined>

should expect this, instead:

const c = of(
  false as const,
  0 as const,
  "hi" as const,
  -0 as const,
  0n as const,
  "" as const,
  null,
  undefined
).pipe(takeWhile(Boolean)); // $ExpectType Observable<"hi">

The goal of this PR is to make the Boolean constructor typings of takeWhile (when the inclusive flag is set to false) consistent with the typings of filter.

[kwonoj]

Not sure if I understood correctly, but looks like current signature behaves correct? Takewhile doesn't change what source emits but only limits when to stop emit. Would you mind explain bit as I may miss something?

[josepot]

Not sure if I understood correctly, but looks like current signature behaves correct? Takewhile doesn't change what source emits but only limits when to stop emit. Would you mind explain bit as I may miss something?

If the inclusive flag is set to false (which it's its default value) then if the takeWhile operator is used with the Boolean constructor the resulting observable won't emit falsy values. For instance:

of('foo', 'bar', null).pipe(
  takeWhile(Boolean)
)

will only emit strings, it would never emit null.

That's why I think that it makes sense to change the typings of the Boolean constructor (when the inclusive flag is set to false), so that the typings of the resulting Observable exclude the falsy values, like filter does.

[cartant]

LGTM. Thanks.

[benlesh]

Thank you, @josepot!