feat(AjaxResponse): add stricter type (AjaxResponseType)
#6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverJAsh
commented
Apr 28, 2021
OliverJAsh
force-pushed
the
oja/ajax-response-type
branch
from
e3b0d39
to
5cb0713
Compare
OliverJAsh
force-pushed
the
oja/ajax-response-type
branch
from
5cb0713
to
4226127
Compare
benlesh
approved these changes
Apr 29, 2021
|
Thanks, @OliverJAsh! (Sorry I accidentally hit the close button there, haha 😅 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: currently
AjaxResponse['type']is typed asstring, but we can use a stricter type for this since we know which strings will be used. This will help usersswitchover the various types.